feat: support scaling in sql backend #14757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanicky
force-pushed
the
peng/scale-model-v2
branch
from
22d8d98 to
40b99a0
Compare
shanicky
commented
Jan 23, 2024
src/meta/node/src/server.rs
Outdated
| @@ -124,6 +124,7 @@ pub async fn rpc_serve( | |||
| Some(backend) => { | |||
| let mut options = sea_orm::ConnectOptions::new(backend.endpoint); | |||
| options | |||
| .sqlx_logging(false) | |||
There was a problem hiding this comment.
here will be reverted before the PR is merged.
shanicky
force-pushed
the
peng/scale-model-v2
branch
3 times, most recently
from
f7b0afb to
d5c06d1
Compare
shanicky
force-pushed
the
peng/scale-model-v2
branch
from
0cb5d21 to
ec1b8aa
Compare
yezizp2012
approved these changes
Jan 31, 2024
auto-merge was automatically disabled
January 31, 2024 23:49
Merge queue setting changed
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
Signed-off-by: Shanicky Chen <[email protected]>
shanicky
added a commit
that referenced
this pull request
Feb 1, 2024
Signed-off-by: Shanicky Chen <[email protected]> Co-authored-by: Shanicky Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
It supports low-level operations but doesn't yet support automatic scaling (lacking the field for table parallelism).
Checklist
./risedev check(or alias,./risedev c)