-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdc): support disable cdc backfill and only consumes from latest changelog #14718
Conversation
cd86185
to
ef3f647
Compare
ef3f647
to
6ccc2a4
Compare
) with ( | ||
snapshot = 'false' | ||
) from mysql_mytest table 'mytest.orders'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I see that we insert Sam
as a record, but where? Do you think it's possible for the cdc tests to be inlined?
Seems a little confusing because we create the table here (in cdc.share_stream.slt
).
But we check for the contents in a separate file: (e2e_test/source/cdc/cdc.check_new_rows.slt
).
Not sure how they are synced up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I see that we insert Sam as a record, but where?
In the e2e-source-test.sh
which is the "main" of e2e test.
And cdc.check_new_rows.slt
is called after cluster restart, which is to test cdc source can resume after recovery. I feel it is also odd to kill the cluster and restart it in the .slt
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For CDC Backfill without snapshot, how do we handle the case where CDC updates contain updates/deletes on a non-existent row (i.e. its from the snapshot which was not read).
609ff02
to
518dc0a
Compare
dceb0df
to
3370a88
Compare
Merge queue setting changed
… changelog (#14718) (#14911) Co-authored-by: StrikeW <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
snapshot
option to allow user to disable cdc backfill and only consumes from the latest changelog.The streaming plan is same as table w/ cdc backfill.
close #14600
related: #13947
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.