Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(error): clean-up direct error formatting (part 4) #14691

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Jan 19, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

See backgrounds in #11443. TL;DR: formatting errors with {} or .to_string can cause the loss of the error source. Use thiserror_ext::Report instead.


Follow-up of

This PR fixes usages in storage. The only remaining module is the connector.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Base automatically changed from bz/format-error-lint-fix-3 to main January 19, 2024 10:29
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao force-pushed the bz/format-error-lint-fix-4 branch from b943017 to 8016811 Compare January 22, 2024 03:57
@BugenZhao BugenZhao marked this pull request as ready for review January 22, 2024 03:57
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the efforts

src/meta/src/hummock/manager/versioning.rs Show resolved Hide resolved
src/storage/compactor/src/server.rs Show resolved Hide resolved
@BugenZhao BugenZhao enabled auto-merge January 22, 2024 08:29
@BugenZhao BugenZhao added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit 6ca7ee3 Jan 22, 2024
25 of 26 checks passed
@BugenZhao BugenZhao deleted the bz/format-error-lint-fix-4 branch January 22, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants