Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): disable LTO for ci-release to resolve build timeout in main-cron #14677

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Jan 19, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

image

30 min is barely enough for the cargo build command, but sometimes it timeouts due to the fluctuation and other phases.

https://buildkite.com/risingwavelabs/main-cron/builds/1559#018d1d50-28d4-4f64-8175-e842dd03e634

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Jan 19, 2024
@BugenZhao BugenZhao force-pushed the bz/main-cron-increase-build branch from d19f71b to d545479 Compare January 19, 2024 05:50
@BugenZhao BugenZhao requested a review from a team as a code owner January 19, 2024 05:50
@BugenZhao BugenZhao force-pushed the bz/main-cron-increase-build branch from d545479 to d19f71b Compare January 19, 2024 05:52
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may consider turn off lto for ci-release

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

@BugenZhao
Copy link
Member Author

@BugenZhao
Copy link
Member Author

Have a try: buildkite.com/risingwavelabs/main-cron/builds/1562#018d2054-8b11-40c2-80b0-ecc4546da7ee

Wow, so fast after disabling LTO. 😄

image

@BugenZhao BugenZhao changed the title fix(ci): increase build timeout in main-cron fix(ci): disable LTO for ci-release to resolve build timeout in main-cron Jan 19, 2024
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao enabled auto-merge January 19, 2024 06:31
@BugenZhao BugenZhao added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 4454cd1 Jan 19, 2024
26 of 27 checks passed
@BugenZhao BugenZhao deleted the bz/main-cron-increase-build branch January 19, 2024 07:22
Little-Wallace pushed a commit that referenced this pull request Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants