fix: fix and refactor _rw_kafka_timestamp related code #14653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabVersion
reviewed
Feb 1, 2024
Comment on lines
+310
to
+277
| /// For kafka source, the column is always available. But when `CREATE TABLE` with kafka connector, | ||
| /// it's not available. |
There was a problem hiding this comment.
the column in the source catalog, but we prune it when building a streaming job.
we do not know it because we cannot describe source 🤣
Comment on lines
89
to
91
| // compatible code: handle legacy column `_rw_kafka_timestamp` | ||
| // the column is auto added for all kafka source to empower batch query on source | ||
| // solution: rewrite the column `additional_column_type` to Timestamp |
There was a problem hiding this comment.
I put the compatibility code here to prevent changing the catalog. I don't see how to deal with this part.
|
This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review. |
xxchan
force-pushed
the
xxchan/substantial-wildebeest
branch
from
899da60 to
6c654ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#14627 #14636
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.