Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add php client test into ci pipeline #14649

Merged
merged 4 commits into from
Jan 18, 2024
Merged

test: add php client test into ci pipeline #14649

merged 4 commits into from
Jan 18, 2024

Conversation

xuefengze
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

https://buildkite.com/risingwavelabs/integration-tests/builds/589

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xuefengze xuefengze requested a review from lmatz January 18, 2024 08:03
@github-actions github-actions bot added the component/test Test related issue. label Jan 18, 2024
@lmatz
Copy link
Contributor

lmatz commented Jan 18, 2024

link #14640 as it was first found in PHP client test, although it does not block the tests

Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@lmatz lmatz added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit db7b8eb Jan 18, 2024
7 of 8 checks passed
@lmatz lmatz deleted the fz/php_client_test branch January 18, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants