feat(frontend): define generated column on table/source with external schema #14644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hao/generated_column_in_create_source
yuhao-su
added
the
user-facing-changes
st1page
approved these changes
Jan 19, 2024
tabVersion
reviewed
Jan 19, 2024
| @@ -80,6 +80,8 @@ macro_rules! impl_fmt_display { | |||
| pub struct CreateSourceStatement { | |||
| pub if_not_exists: bool, | |||
| pub columns: Vec<ColumnDef>, | |||
| // The wildchar position in columns defined in sql. Only exist when using external schema. | |||
There was a problem hiding this comment.
what doesexternal schema refer to
There was a problem hiding this comment.
Schema from external connector
| let has_items = !columns.is_empty() | ||
| || !constraints.is_empty() | ||
| || !watermarks.is_empty() | ||
| || wildcard_idx.is_some(); |
There was a problem hiding this comment.
do we store the *'s index in catalog?
Is it true that the columns on the left of * means defined schema and on the right means generated columns.
There was a problem hiding this comment.
It will be in the sql string in catalog
Is it true that the columns on the left of * means defined schema and on the right means generated columns
No, * means all columns from external source
xxchan
reviewed
Jan 19, 2024
| cols_from_sql.append(&mut cols_from_source); | ||
| cols_from_sql.append(&mut cols_from_sql_r); | ||
| Ok(cols_from_sql) | ||
| } | ||
| } else { | ||
| // TODO(yuhao): https://github.com/risingwavelabs/risingwave/issues/12209 |
There was a problem hiding this comment.
nit: This TODO should be removed
|
this feature does not seem to work with Postgres CDC source create table courses (*) from pg_mydb table 'public.courses';
ERROR: Failed to run the queryCaused by these errors (recent errors listed first):
1: gRPC request to meta service failed: Internal error
2: failed to validate CDC table
3: source cannot pass validation: INVALID_ARGUMENT: Primary key mismatch |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
close #12209
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
For table/source with schema from external connector, we use
*to represent all columns from the external connector.Also we can define a generated column on able/source with an external connector.
example: