refactor(storage): refactor compaction event loop #14631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto li0k/storage_compact_event_loop
…nto li0k/storage_compact_event_loop
|
src/meta/src/hummock/manager/mod.rs
Outdated
| let mut event_loop_iteration_now = Instant::now(); | ||
| loop { | ||
| let shutdown_rx_shared = shutdown_rx_shared.clone(); | ||
| async fn compact_task_event_handler( |
There was a problem hiding this comment.
How about define this method outside
…nto li0k/storage_compact_event_loop
…nto li0k/storage_compact_event_loop
…nto li0k/storage_compact_event_loop
…nto li0k/storage_compact_event_loop
…nto li0k/storage_compact_event_loop
hzxa21
approved these changes
Jan 31, 2024
Comment on lines
2755
to
-2756
| let mut compactor_alive = true; | ||
| let (context_id, compactor_stream_req) = result; | ||
|
|
||
| let (context_id, compactor_stream_req): (_, (std::option::Option<std::result::Result<SubscribeCompactionEventRequest, _>>, _)) = result; | ||
| let (event, create_at, stream) = match compactor_stream_req { | ||
| (Some(Ok(req)), stream) => { | ||
| (req.event.unwrap(), req.create_at, stream) | ||
| } | ||
|
|
||
| (Some(Err(err)), _stream) => { | ||
| tracing::warn!(error = %err.as_report(), "compactor {} leaving the cluster with err", context_id); | ||
| hummock_manager.compactor_manager | ||
| .remove_compactor(context_id); |
Comment on lines
2762
to
-2763
|
|
||
| (Some(Err(err)), _stream) => { | ||
| tracing::warn!(error = %err.as_report(), "compactor {} leaving the cluster with err", context_id); | ||
| hummock_manager.compactor_manager | ||
| .remove_compactor(context_id); | ||
| tracing::warn!(error = %err.as_report(), "compactor stream {} poll with err, recv stream may be destroyed", context_id); | ||
| continue | ||
| } | ||
|
|
||
| _ => { | ||
| tracing::warn!("compactor {} leaving the cluster", context_id); | ||
| hummock_manager.compactor_manager | ||
| .remove_compactor(context_id); |
There was a problem hiding this comment.
remove_compactor will remove the tx via context_id. Therefore, we only remove tx when send fails and rx when recv fails.
In short: avoid having multiple branches operating removing tx
…nto li0k/storage_compact_event_loop
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9425213 | Triggered | Generic Password | dbc5c52 | ci/scripts/regress-test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#13879
Introduce a dedicated loop for CPU-bound / IO-bound events to avoid slow events from occupying the event loop thread for a long time, causing the basic event loop to starve.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.