fix(storage): should use epoch with the maximum offset when get #14607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxa21
approved these changes
Jan 16, 2024
| @@ -684,7 +685,11 @@ impl HummockVersionReader { | |||
| Sstable::hash_for_bloom_filter(dist_key.as_ref(), read_options.table_id.table_id()) | |||
| }); | |||
|
|
|||
| let full_key = FullKey::new(read_options.table_id, TableKey(table_key.clone()), epoch); | |||
| let full_key = FullKey::new_with_gap_epoch( | |||
There was a problem hiding this comment.
Can you add some documentations on why we need to use MAX_SPILL_OFFSET and add a UT to cover the bug?
There was a problem hiding this comment.
How about UT? Are we planning to add it in later PR?
There was a problem hiding this comment.
Yes, UT will be added after #14557 get merged because we need to remove enable_test_epoch first.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Little-Wallace
pushed a commit
that referenced
this pull request
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fix #14598
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.