refactor(meta): only persist and handle changes when system params actually get updated #14602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugenZhao
changed the title
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/system-param-diff
branch
from
40151de to
cafc647
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 4744 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 2068 | 1 | 2675 | 0 |
Click to see the invalid file list
- src/common/src/system_param/diff.rs
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
changed the title
BugenZhao
changed the title
BugenZhao
changed the title
BugenZhao
changed the title
BugenZhao
commented
Jan 17, 2024
| @@ -202,8 +202,7 @@ pub fn init_risingwave_logger(settings: LoggerSettings) { | |||
| // Configure levels for external crates. | |||
| filter = filter | |||
| .with_target("foyer", Level::WARN) | |||
| .with_target("aws_sdk_ec2", Level::INFO) | |||
| .with_target("aws_sdk_s3", Level::INFO) | |||
| .with_target("aws", Level::INFO) | |||
There was a problem hiding this comment.
aws_smithy_http is too verbose under debug mode (with default level set to DEBUG), especially that it yields spans with DEBUG level frequently.
fuyufjh
approved these changes
Jan 18, 2024
Comment on lines
+45
to
+46
| pub struct SystemParamsReader<I = PbSystemParams> { | ||
| inner: I, |
There was a problem hiding this comment.
Here we want to create a reader with the reference to a PbSystemParams:
risingwave/src/common/src/system_param/mod.rs
Line 327 in 3a54d0b
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
TennyZhuang
pushed a commit
that referenced
this pull request
Feb 2, 2024
…tually get updated (#14602) Signed-off-by: Bugen Zhao <[email protected]>
TennyZhuang
pushed a commit
that referenced
this pull request
Feb 2, 2024
…tually get updated (#14602) Signed-off-by: Bugen Zhao <[email protected]>
TennyZhuang
pushed a commit
that referenced
this pull request
Feb 2, 2024
…tually get updated (#14602) Signed-off-by: Bugen Zhao <[email protected]>
TennyZhuang
pushed a commit
that referenced
this pull request
Feb 2, 2024
…tually get updated (#14602) Signed-off-by: Bugen Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Only persist and handle changes when system params actually get updated.
SystemParamsDiffto show the updates.CommonHandlerintroduced in feat: enable or disable tracing with system params #14528 will now directly run on the diff.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.