refactor(frontend): make frontend compute runtime configurable #14597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/common/src/config.rs
Outdated
|
|
||
| #[serde(default = "default::streaming::compute_runtime_worker_threads")] | ||
| /// compute runtime worker threads | ||
| pub compute_runtime_worker_threads: usize, |
There was a problem hiding this comment.
This should be moved to BatchConfig, since this is used for configuring executions in batch.
src/common/src/config.rs
Outdated
|
|
||
| #[serde(default = "default::streaming::compute_runtime_worker_name")] | ||
| /// compute runtime worker name | ||
| pub compute_runtime_worker_name: String, |
There was a problem hiding this comment.
Do we really need this?
src/frontend/src/session.rs
Outdated
| compute_runtime: Self::create_compute_runtime(), | ||
| compute_runtime: Arc::new(BackgroundShutdownRuntime::from( | ||
| Builder::new_multi_thread() | ||
| .worker_threads(4) |
There was a problem hiding this comment.
We already generated default value for config, why not use config's value?
There was a problem hiding this comment.
Fixed, directly use the default value in config
src/common/src/config.rs
Outdated
|
|
||
| #[serde(default = "default::batch::compute_runtime_worker_threads")] | ||
| /// compute runtime worker threads | ||
| pub compute_runtime_worker_threads: usize, |
There was a problem hiding this comment.
Suggested change
| pub compute_runtime_worker_threads: usize, | |
| pub frontend_compute_runtime_worker_threads: usize, |
I suggest to rename to this since we have also runtime for batch in compute node, adding this makes things more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title, set some parameters in
RwConfig. Try to solve #10782Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.