Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename system catalog field total_memory_bytes total_cpu_cores #14594

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

yuhao-su
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

total_cpu_cores and total_memory_bytes are mostly used in the context of user set parameters, rename them to start with system_ so that we know they are system resources.

close #13927

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yuhao-su yuhao-su requested a review from zwang28 January 16, 2024 07:14
@github-actions github-actions bot added the type/fix Bug fix label Jan 16, 2024
@yuhao-su yuhao-su enabled auto-merge January 16, 2024 08:11
@TennyZhuang TennyZhuang changed the title fix: rename system catalog field total_memory_bytes total_cpu_cores chore: rename system catalog field total_memory_bytes total_cpu_cores Jan 16, 2024
@yuhao-su yuhao-su added this pull request to the merge queue Jan 16, 2024
@github-actions github-actions bot added type/chore and removed type/fix Bug fix labels Jan 16, 2024
Merged via the queue into main with commit 83e829e Jan 16, 2024
28 of 29 checks passed
@yuhao-su yuhao-su deleted the yuhao/rename_system_catalog_field branch January 16, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The total_memory_bytes of cn displayed in meta is not the cn config total_memory_bytes
3 participants