-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): derive Copy
for DeltaBTreeMap
#14579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
9 tasks
This was referenced Jan 15, 2024
BugenZhao
approved these changes
Jan 16, 2024
@@ -15,6 +15,7 @@ ignored = ["workspace-hack"] | |||
normal = ["workspace-hack"] | |||
|
|||
[dependencies] | |||
educe = "0.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, why does it become a dedicated crate. 😄
stdrc
force-pushed
the
rc/sentinel-cmp-by
branch
from
January 16, 2024 04:40
8019754
to
61647ed
Compare
stdrc
force-pushed
the
rc/delta-btree-map-copy
branch
from
January 16, 2024 04:41
8f1f713
to
77f671d
Compare
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
stdrc
force-pushed
the
rc/delta-btree-map-copy
branch
from
January 17, 2024 02:17
77f671d
to
bfdb4f3
Compare
This was referenced Jan 18, 2024
Little-Wallace
pushed a commit
that referenced
this pull request
Jan 20, 2024
Signed-off-by: Richard Chien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Use
educe
to deriveCopy
forDeltaBTreeMap
so that it can be copied despite the copiability ofT
.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.