Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): derive Copy for DeltaBTreeMap #14579

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Jan 15, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Use educe to derive Copy for DeltaBTreeMap so that it can be copied despite the copiability of T.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@stdrc stdrc requested a review from a team as a code owner January 15, 2024 14:23
@@ -15,6 +15,7 @@ ignored = ["workspace-hack"]
normal = ["workspace-hack"]

[dependencies]
educe = "0.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, why does it become a dedicated crate. 😄

@stdrc stdrc force-pushed the rc/sentinel-cmp-by branch from 8019754 to 61647ed Compare January 16, 2024 04:40
@stdrc stdrc force-pushed the rc/delta-btree-map-copy branch from 8f1f713 to 77f671d Compare January 16, 2024 04:41
Base automatically changed from rc/sentinel-cmp-by to main January 16, 2024 10:34
@stdrc stdrc force-pushed the rc/delta-btree-map-copy branch from 77f671d to bfdb4f3 Compare January 17, 2024 02:17
@stdrc stdrc enabled auto-merge January 17, 2024 02:18
@stdrc stdrc added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 3f3ef99 Jan 17, 2024
27 of 28 checks passed
@stdrc stdrc deleted the rc/delta-btree-map-copy branch January 17, 2024 03:07
Little-Wallace pushed a commit that referenced this pull request Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants