refactor(test): refactor scaling tests for arrangement backfill #14577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
commented
Jan 16, 2024
|
Tested with arrangement backfill here 03ba6bf |
chenzl25
approved these changes
Jan 16, 2024
BugenZhao
reviewed
Jan 16, 2024
| @@ -32,6 +32,7 @@ const MV5: &str = "create materialized view m5 as select * from m4;"; | |||
| async fn test_simple_cascade_materialized_view() -> Result<()> { | |||
| let mut cluster = Cluster::start(Configuration::for_scale()).await?; | |||
| let mut session = cluster.start_session(); | |||
| let arrangement_backfill_is_enabled = session.is_arrangement_backfill_enabled().await?; | |||
There was a problem hiding this comment.
Why could this vary during runtime? Didn't quite get it. 😕
There was a problem hiding this comment.
I assume it's for the tests to pass when the default value for enable_arrangment_backfill is set to true manually.
Can we integrate the tests with arrangement backfill into CI?
There was a problem hiding this comment.
I assume it's for the tests to pass when the default value for enable_arrangment_backfill is set to true manually.
Can we integrate the tests with arrangement backfill into CI?
Yeah that's correct. Will do in separate PR, requires more refactor.
kwannoel
force-pushed
the
kwannoel/arrangement-backfill-scale
branch
from
c900f45 to
9e8400d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Only tests on
no_shuffleopt-in to useno_shuffle_backfill. For the other tests, we can let them remain as-is.We also add in a new test to test compatibility of arrangement backfill with auto parallelism and low-level scaling interface.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.