Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use force mode with risectl unregister-workers. #14575

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

shanicky
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add --check-fragment-occupied flag to enhance unregister_workers function

Implemented a new feature in unregister_workers and updated CLI options to improve worker unregistering process.

  • Addition of a boolean parameter check_fragment_occupied to unregister_workers in reschedule.rs.
  • Modification of unregister_workers to include a check for an occupied fragment if check_fragment_occupied is true.
  • Integration of check_fragment_occupied as a CLI argument (--check-fragment-occupied) with a default value of false in MetaCommands::UnregisterWorkers within lib.rs.
  • Update the start_impl function call to unregister_workers to pass the new CLI argument.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@shanicky shanicky enabled auto-merge January 15, 2024 10:09
@shanicky shanicky added this pull request to the merge queue Jan 15, 2024
Merged via the queue into main with commit f2af4e6 Jan 15, 2024
27 of 28 checks passed
@shanicky shanicky deleted the peng/unregister-worker-update branch January 15, 2024 10:51
Little-Wallace pushed a commit that referenced this pull request Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants