Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): show error in web frontend when heap dump not enabled #14571

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

yuhao-su
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #14540

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yuhao-su yuhao-su requested review from fuyufjh and BugenZhao January 15, 2024 09:01
@github-actions github-actions bot added the type/fix Bug fix label Jan 15, 2024
yuhao-su

This comment was marked as off-topic.

@yuhao-su
Copy link
Contributor Author

image

@yuhao-su yuhao-su enabled auto-merge January 15, 2024 09:14
@yuhao-su yuhao-su added this pull request to the merge queue Jan 15, 2024
Merged via the queue into main with commit 5565933 Jan 15, 2024
29 of 30 checks passed
@yuhao-su yuhao-su deleted the yuhao/heap_dump_error_msg branch January 15, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(dashboard): memory profiling dump failure was not shown to users
3 participants