Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: estimate size for topn cache extract_if #14564

Merged
merged 1 commit into from
Jan 15, 2024

fixx

ca099f5
Select commit
Loading
Failed to load commit list.
Merged

fix: estimate size for topn cache extract_if #14564

fixx
ca099f5
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-01-15 06:59:47 ago

0 / 8 tasks completed

8 tasks still to be completed

Details

Required Tasks

Task Status
I have written necessary rustdoc comments Incomplete
I have added necessary unit tests and integration tests Incomplete
I have added test labels as necessary. See details. Incomplete
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). Incomplete
My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). Incomplete
All checks passed in ./risedev check (or alias, ./risedev c) Incomplete
My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) Incomplete
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) Incomplete
Are there any other places that the size is not correctly maintained? Incomplete
Why this kv_heap_size stuff is in TopNCacheState? It looks like a general BTreeMapWithEstimateSize or sth. Incomplete