fix(stream): arrangement backfill background ddl #14563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
changed the title
kwannoel
commented
Jan 24, 2024
| @@ -450,54 +451,58 @@ where | |||
| "backfill_finished_wait_for_barrier" | |||
| ); | |||
| // If not finished then we need to update state, otherwise no need. | |||
| if let Message::Barrier(barrier) = &msg | |||
| && !is_completely_finished | |||
There was a problem hiding this comment.
Previously we wait for this flag to pass. However is_completely_finished could be true on recovery, if backfill is completed already.
In that case, we should just yield the barrier and stop waiting.
There was a problem hiding this comment.
IIUC, after recovery, the backfill state may be inconsistent with the CreateMaterializedTracker state, so we need to notify the progress to finish every time after recovery.
There was a problem hiding this comment.
Yes, we will always notify see https://github.com/risingwavelabs/risingwave/pull/14563/files#r1464421419. It is outside of the if-else block.
kwannoel
commented
Jan 24, 2024
|
|
||
| self.progress | ||
| .finish(barrier.epoch.curr, total_snapshot_processed_rows); | ||
| tracing::trace!( |
chenzl25
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fixes 2 bugs:
Adds background ddl + arrangement backfill as a test step in
main-cron.yml.Reduces the logs being uploaded by:
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.