Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): remove enable_test_epoch and modify epochs used by all unit tests to be realistic #14557

Merged
merged 52 commits into from
Mar 11, 2024

resolve comments, can merge

6db3372
Select commit
Loading
Failed to load commit list.
Merged

refactor(storage): remove enable_test_epoch and modify epochs used by all unit tests to be realistic #14557

resolve comments, can merge
6db3372
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks skipped Mar 8, 2024 in 6s

You tagged this GitGuardian alert as a false positive

1 secret were uncovered from the scan of 52 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #14557: wcy/remove_enable_test_epoch 👉 main
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password 7e02709 ci/scripts/regress-test.sh View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!