feat(sql-udf): add semantic check when creating sql udf #14549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzhseh
requested review from
wangrunji0408,
xxchan,
TennyZhuang and
BugenZhao
TennyZhuang
reviewed
Jan 22, 2024
| @@ -57,12 +57,12 @@ create function fib(INT) returns int | |||
| end;'; | |||
|
|
|||
| # The execution will eventually exceed the pre-defined max stack depth | |||
| statement error function fib calling stack depth limit exceeded | |||
| select fib(100); | |||
| # statement error function fib calling stack depth limit exceeded | |||
There was a problem hiding this comment.
Note: This will also prevent recursion from happening, future support to recursion may need extra work around.
Since we don't allow users to create recursion function if semantic check is enabled.
TennyZhuang
reviewed
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As titled, this PR adds semantic check for sql udf at definiiton time.
Which means, if any non-existence function (including sql udf, built-in scalar functions, etc.) is called inside the sql udf function body definition, this will be directly rejected, same as pg's behavior.
Note: This will also prevent recursion from happening, future support to recursion may need extra work around.
Reference: #14392 (comment).
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.