Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): add additional check in nats list_splits #14546

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

yufansong
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In #12942, once a time, there is some connection error in source between rw and nats which result in the compute node crash. The root cause: when source executor call the list_splits function, nats didn't provide the API for it, so currently we directly return 0. But if the connection has error, executor will crash in the following logic.

So I add a client in NatsSplitEnumerator, and when call list_splits, will check the connection state first. If return State::Connected, continue, otherwise throw error.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yufansong yufansong requested a review from tabVersion January 12, 2024 17:52
@github-actions github-actions bot added the type/fix Bug fix label Jan 12, 2024
@yufansong yufansong enabled auto-merge January 12, 2024 19:44
@yufansong yufansong added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 2bec2ed Jan 12, 2024
26 of 27 checks passed
@yufansong yufansong deleted the yufan/fix-nats-connection branch January 12, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connector(nats): need to validate the connection in list_split function
2 participants