-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): add ObjectStore trait simulator support #14545
Conversation
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
Can we just apply all the current deterministic tests via this new simulator in this PR? |
Yes, after this pr we can use ObjectStore trait simulator as the only simulator, instead of S3 simulator |
Signed-off-by: Kevin Axel <[email protected]>
Any updates? Ping @wangrunji0408 @KveinAxel |
I will review soon... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the work.
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Now deterministic test can use ObjectStore simulation instead of s3 simulation
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.