Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): add ObjectStore trait simulator support #14545

Merged
merged 12 commits into from
Jan 30, 2024

Conversation

KveinAxel
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Now deterministic test can use ObjectStore simulation instead of s3 simulation

// s3
-handle
-    .create_node()
-    .name("s3")
-    .ip("192.168.12.1".parse().unwrap())
-    .init(move || async move {
-        aws_sdk_s3::server::SimServer::default()
-            .with_bucket("hummock001")
-            .serve("0.0.0.0:9301".parse().unwrap())
-            .await
-    })
-    .build();
+// object_store_sim
+handle
+   .create_node()
+    .name("object_store_sim")
+    .ip("192.168.12.1".parse().unwrap())
+    .init(move || async move {
+        ObjectStoreSimServer::builder()
+            .serve("0.0.0.0:9301".parse().unwrap())
+            .await
+    })
+    .build();

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@KveinAxel KveinAxel requested a review from a team as a code owner January 12, 2024 14:44
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
@wcy-fdu
Copy link
Contributor

wcy-fdu commented Jan 14, 2024

Can we just apply all the current deterministic tests via this new simulator in this PR?

@wcy-fdu wcy-fdu requested a review from hzxa21 January 15, 2024 02:11
@KveinAxel
Copy link
Contributor Author

Can we just apply all the current deterministic tests via this new simulator in this PR?

Yes, after this pr we can use ObjectStore trait simulator as the only simulator, instead of S3 simulator

@fuyufjh
Copy link
Member

fuyufjh commented Jan 25, 2024

Any updates? Ping @wangrunji0408 @KveinAxel

@wangrunji0408
Copy link
Contributor

I will review soon...

Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the work.

src/object_store/src/object/sim/mod.rs Show resolved Hide resolved
src/object_store/src/object/sim/mod.rs Show resolved Hide resolved
src/object_store/src/object/sim/mod.rs Outdated Show resolved Hide resolved
src/object_store/src/object/sim/mod.rs Outdated Show resolved Hide resolved
src/object_store/src/object/sim/service.rs Outdated Show resolved Hide resolved
src/object_store/src/object/sim/service.rs Outdated Show resolved Hide resolved
src/object_store/src/object/sim/service.rs Outdated Show resolved Hide resolved
@wangrunji0408 wangrunji0408 added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit a0574b7 Jan 30, 2024
27 of 28 checks passed
@wangrunji0408 wangrunji0408 deleted the wff/sim-object-store branch January 30, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants