Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): maintain snapshot of running actors instead of resolving it every time for barrier #14517

Merged
merged 11 commits into from
Jan 16, 2024

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Jan 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #8015 .

Some changes in this PR:

  1. maintaining a snapshot of running actors in barrier state, it will be incrementally update according to the actor changes of each barrier.
  2. drop table fragments directly before issuing a drop barrier, which is the main purpose of introducing this refactoring, so that we can easily support sql-backend.
  3. some changes on the drop and reschedule command to expose actor changes for barrier manager.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yezizp2012 yezizp2012 changed the title refactor: maintain snapshot of running actors instead of resolving it every time for barrier refactor(meta): maintain snapshot of running actors instead of resolving it every time for barrier Jan 11, 2024
@BugenZhao
Copy link
Member

Does this resolve #8015?

@yezizp2012
Copy link
Member Author

Does this resolve #8015?

👍 Yes exactly.

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM!

Is it possible (and easy) to keep the original impl so that we can add a debug assertion to check if everything work well with the incremental maintenance?

src/meta/src/barrier/state.rs Outdated Show resolved Hide resolved
src/meta/src/barrier/info.rs Outdated Show resolved Hide resolved
src/meta/src/barrier/command.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM! Thanks for the PR

src/meta/src/barrier/mod.rs Outdated Show resolved Hide resolved
src/meta/src/barrier/recovery.rs Outdated Show resolved Hide resolved
src/meta/src/stream/stream_manager.rs Show resolved Hide resolved
@yezizp2012 yezizp2012 force-pushed the refactor/actor-aware-only-barrier branch from 24669d3 to bc82b88 Compare January 16, 2024 11:17
src/meta/src/barrier/state.rs Show resolved Hide resolved
@yezizp2012 yezizp2012 enabled auto-merge January 16, 2024 11:43
@yezizp2012 yezizp2012 added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit b1cdb98 Jan 16, 2024
26 of 27 checks passed
@yezizp2012 yezizp2012 deleted the refactor/actor-aware-only-barrier branch January 16, 2024 12:15
@BugenZhao
Copy link
Member

Is it possible (and easy) to keep the original impl so that we can add a debug assertion to check if everything work well with the incremental maintenance?

🥺

@yezizp2012
Copy link
Member Author

Is it possible (and easy) to keep the original impl so that we can add a debug assertion to check if everything work well with the incremental maintenance?

🥺

Oh, I added the assertion check in function pre_apply and post_apply. Is this what you mean to keep? 🥵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meta: incremental resolve_actor_info in barrier manager
3 participants