Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compaction): fix compatible for vnode partition #14489

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

Little-Wallace
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#12534 will compact normal non-overlapping level to partitioned level.
But we check whether a level need to be compacted to partitioned level by check the variable of structure Levels.
If this cluster upgraded from an old version, the variable vnode_partition_count of Levels would never be changed, and we will treat it as a no-partitioned group.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Little-Wallace <[email protected]>
@github-actions github-actions bot added the type/fix Bug fix label Jan 10, 2024
@Little-Wallace Little-Wallace added this pull request to the merge queue Jan 11, 2024
Merged via the queue into main with commit 4b229af Jan 11, 2024
27 of 29 checks passed
@Little-Wallace Little-Wallace deleted the wallace/fix-compatibility branch January 11, 2024 03:09
Little-Wallace added a commit that referenced this pull request Jan 20, 2024
Little-Wallace added a commit that referenced this pull request Jan 22, 2024
Li0k pushed a commit that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants