Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sql-udf): update test cases for implicit type cast support #14458

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

xzhseh
Copy link
Contributor

@xzhseh xzhseh commented Jan 9, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled, since implicit type cast for udf has been supported in #14338.

P.S. Create function will be much slower (~4x) after supporting implicit type cast, but it's alright.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

The previous docs for sql udf in #14139 needs to be updated, specifically we don't need to explicit cast multiple types when calling sql udf.

@xzhseh xzhseh self-assigned this Jan 9, 2024
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangrunji0408
Copy link
Contributor

P.S. Create function will be much slower (~4x) after supporting implicit type cast, but it's alright.

How did you measure that?

@xzhseh
Copy link
Contributor Author

xzhseh commented Jan 9, 2024

How did you measure that?

Previously the overall test cases will finished in ~1500 ms, currently ~6000ms.
And after manually reviewing the implementation in #14338 & testing, it seems that the delay is mainly due to create function.
Anyways I think this is worth and acceptable. 😄

@xzhseh xzhseh added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit cd787f6 Jan 9, 2024
26 of 27 checks passed
@xzhseh xzhseh deleted the xzhseh/sql-udf-test-update branch January 9, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants