-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: local barrier manager use prev epoch to track barrier state #14436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
||
/// Current barrier collection state. | ||
state: ManagedBarrierState, | ||
|
||
/// Save collect `CompleteReceiver`. | ||
collect_complete_receiver: HashMap<u64, CompleteReceiver>, | ||
|
||
streaming_metrics: Arc<StreamingMetrics>, | ||
/// Record all unexpected exited actors. | ||
failure_actors: HashMap<ActorId, StreamError>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason we wanna keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be consistent with the original logic. We can save the error and early return the error when handling inject_barrier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! LGTM!
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Split from #14377 as suggested in #14377 (comment)
Refactor includes the following changes:
prev_epoch
as the key of barrier state map. Previously we usecurr_epoch
.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.