feat(object store): introduce new s3 object store via OpenDAL #14409
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 4697 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 2049 | 1 | 2647 | 0 |
Click to see the invalid file list
- src/object_store/src/object/opendal_engine/opendal_s3.rs
|
I have verified the correctness of OpenDAL s3.
Next, we need to do perf test and stability test for the new OpenDAL S3, but before that we need to apply this change in RisingWave Operator and Kube Bench. I have created an issue for this, and will start testing after this is done. So let's merge this PR first to allow other components to be easily tested. @hzxa21 The next PR will switch current minio to use OpenDAL S3. |
|
Longevity test Nexmark perf test is running |
…nto wcy/opendal_s3
|
Add some enhancement for opendal s3:
|
…nto wcy/opendal_s3
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9425213 | Triggered | Generic Password | 50bc801 | ci/scripts/regress-test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
src/object_store/src/object/opendal_engine/opendal_object_store.rs
Outdated
Show resolved
Hide resolved
Umm... never mind, I am build RisingWave image right now, which need to be consistent with |
…nto wcy/opendal_s3
…nto wcy/opendal_s3 consistent with nightly-0207 for perf test.
|
Metabase link: http://metabase.risingwave-cloud.xyz/dashboard/241-nexmark-blackhole-1cn-anti-affinity-rw-avg-source-throughput?start_date=2024-02-07&namespace= |
Take eyes on q104:grafana urlopendal-s3:https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?orgId=1&var-da[…]ar-namespace=nexmark-kafka-benchmark-20240207-124259 metrics
Before introducing concurrent uploading for opendal-s3, this metrics opendal side will be 100 times slower, but now both sides are basically the same.
Also streaming upload finish avg are basically the same now.
Previously, for this metrics(read p99/pmax), there are a lot of burrs in opendal side, we find that it's because the retry strategy is different. After turning retry config to be consistent with s3-sdk, this metrics are alse basically the same now. Above are three abnormal metrics found in last time benchmark, and now it seems that all have been fixed or optimized. @Xuanwo Abnormal metrics found this time
|
|
What does |
checkpointing |
|
Hi, @wcy-fdu, do we have a final report about this? Is there anything that opendal could improve? |
We will go ahead do some perf test on main branch, comparing with everyday's nightly. |
Got it, let's figure out it. |
Co-authored-by: William Wen <[email protected]>
#15215) Co-authored-by: congyi wang <[email protected]> Co-authored-by: William Wen <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
detail in #14321
Checklist
- [ ] I have written necessary rustdoc comments- [ ] I have added necessary unit tests and integration tests- [ ] I have added test labels as necessary. See details.- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).- [ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future)../risedev check(or alias,./risedev c)- [ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)- [ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)Documentation
- [ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.