Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(over window): add some short-circuit logic in find_affected_ranges and some other refactoring #14385

Merged
merged 8 commits into from
Jan 12, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Jan 5, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Introduce a new type RowsFrameBounds to represent ROWS frame bounds;
  • Add short circuit logic in find_affected_ranges to avoid wasted computation.

This is a preliminary work for RANGE frame support.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@stdrc stdrc force-pushed the rc/refactor-over-window-rows-frame branch from 513a2a6 to cb73122 Compare January 9, 2024 09:37
@stdrc stdrc requested a review from BugenZhao January 9, 2024 12:13
@stdrc stdrc force-pushed the rc/refactor-over-window-rows-frame branch from a4d768f to ccbfdac Compare January 10, 2024 05:48
@stdrc stdrc changed the base branch from main to rc/extract-range-utils January 10, 2024 05:48
@stdrc stdrc force-pushed the rc/extract-range-utils branch from 4e1a4dd to 35e9ec9 Compare January 10, 2024 06:38
@stdrc stdrc force-pushed the rc/refactor-over-window-rows-frame branch from ccbfdac to 2c4bad3 Compare January 10, 2024 06:39
@stdrc stdrc force-pushed the rc/extract-range-utils branch from 35e9ec9 to 88f586d Compare January 10, 2024 07:38
@stdrc stdrc force-pushed the rc/refactor-over-window-rows-frame branch from 45c7752 to ad093d2 Compare January 10, 2024 07:38
Base automatically changed from rc/extract-range-utils to main January 10, 2024 08:06
stdrc added 8 commits January 10, 2024 16:07
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc force-pushed the rc/refactor-over-window-rows-frame branch from ad093d2 to b7405ac Compare January 10, 2024 08:08
@stdrc
Copy link
Member Author

stdrc commented Jan 12, 2024

I'm doing a big refactoring for find_affected_ranges, let's merge this PR first cuz my refactor branch is based on this.

@stdrc stdrc added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 69d8b6e Jan 12, 2024
27 of 28 checks passed
@stdrc stdrc deleted the rc/refactor-over-window-rows-frame branch January 12, 2024 08:25
Little-Wallace pushed a commit that referenced this pull request Jan 20, 2024
…_ranges` and some other refactoring (#14385)

Signed-off-by: Richard Chien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants