-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(over window): add some short-circuit logic in find_affected_ranges
and some other refactoring
#14385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
stdrc
force-pushed
the
rc/refactor-over-window-rows-frame
branch
from
January 9, 2024 09:37
513a2a6
to
cb73122
Compare
9 tasks
This was referenced Jan 10, 2024
stdrc
force-pushed
the
rc/refactor-over-window-rows-frame
branch
from
January 10, 2024 05:48
a4d768f
to
ccbfdac
Compare
stdrc
force-pushed
the
rc/extract-range-utils
branch
from
January 10, 2024 06:38
4e1a4dd
to
35e9ec9
Compare
stdrc
force-pushed
the
rc/refactor-over-window-rows-frame
branch
from
January 10, 2024 06:39
ccbfdac
to
2c4bad3
Compare
stdrc
force-pushed
the
rc/extract-range-utils
branch
from
January 10, 2024 07:38
35e9ec9
to
88f586d
Compare
stdrc
force-pushed
the
rc/refactor-over-window-rows-frame
branch
from
January 10, 2024 07:38
45c7752
to
ad093d2
Compare
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
stdrc
force-pushed
the
rc/refactor-over-window-rows-frame
branch
from
January 10, 2024 08:08
ad093d2
to
b7405ac
Compare
st1page
approved these changes
Jan 12, 2024
I'm doing a big refactoring for |
Little-Wallace
pushed a commit
that referenced
this pull request
Jan 20, 2024
…_ranges` and some other refactoring (#14385) Signed-off-by: Richard Chien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
RowsFrameBounds
to representROWS
frame bounds;find_affected_ranges
to avoid wasted computation.This is a preliminary work for
RANGE
frame support.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.