Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing update of upstream fragment and actor ids for table replacement #14381

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

yezizp2012
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Jan 5, 2024
@yezizp2012 yezizp2012 changed the title fix: missing update of upstream fragment id for replace table fix: missing update of upstream fragment and actor ids for table replacement Jan 5, 2024
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that we'll get metadata corrupted when CREATE SINK INTO TABLE before this PR? Is there any tests that can cover this?

@yezizp2012
Copy link
Member Author

Does it mean that we'll get metadata corrupted when CREATE SINK INTO TABLE before this PR?

I'm afraid yes, and also when ALTER TABLE ADD/DROP COLUMN. But these two fields are only used for scaling IIUC.

Is there any tests that can cover this?

I'm afraid not, I will add some in scaling integration tests.

@yezizp2012 yezizp2012 force-pushed the fix/update-upstream-fragment-4-replace branch from baa3053 to 2d3817a Compare January 8, 2024 12:50
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. THX!

@yezizp2012 yezizp2012 added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit 31a8568 Jan 9, 2024
26 of 27 checks passed
@yezizp2012 yezizp2012 deleted the fix/update-upstream-fragment-4-replace branch January 9, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants