Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix expr macro doc #14351

Merged
merged 1 commit into from
Jan 15, 2024
Merged

chore: fix expr macro doc #14351

merged 1 commit into from
Jan 15, 2024

Conversation

ZENOTME
Copy link
Contributor

@ZENOTME ZENOTME commented Jan 3, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@ZENOTME ZENOTME changed the title chore: fix expr doc and construct struct with null from pretty chore: fix expr macro doc and construct struct with null from pretty Jan 3, 2024
@ZENOTME ZENOTME requested review from wangrunji0408, stdrc and xiangjinwu and removed request for stdrc January 3, 2024 15:28
@stdrc
Copy link
Member

stdrc commented Jan 15, 2024

Any updates?

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Jan 15, 2024

Any updates?

I think it is completed now. struct part has been fixed in #14497.

@ZENOTME ZENOTME changed the title chore: fix expr macro doc and construct struct with null from pretty chore: fix expr macro doc Jan 15, 2024
@wangrunji0408 wangrunji0408 added this pull request to the merge queue Jan 15, 2024
Merged via the queue into main with commit 75c1076 Jan 15, 2024
28 of 29 checks passed
@wangrunji0408 wangrunji0408 deleted the zj/fix_doc branch January 15, 2024 10:31
Little-Wallace pushed a commit that referenced this pull request Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants