chore: Add type check to alter parallelism statement. #14323
Merged
+68
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shanicky Chen <[email protected]>
Signed-off-by: Shanicky Chen <[email protected]>
yezizp2012
approved these changes
Jan 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
Signed-off-by: Shanicky Chen <[email protected]>
xxhZs
pushed a commit
that referenced
this pull request
Jan 4, 2024
Signed-off-by: Shanicky Chen <[email protected]>
xxhZs
added a commit
that referenced
this pull request
Jan 4, 2024
fix chore: fix typos linted by cSpell (#14306) Signed-off-by: TennyZhuang <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix(over window): fix over window range cache shortcut return (#14311) Signed-off-by: Richard Chien <[email protected]> fix(stream): rowIdGen executor handle invisible delete record (#14237) feat(storage): Improve task measurement on the compactor side with parallelism (#13812) feat: introduce rw_streaming_parallelism system view (#14261) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> chore: Add type check to alter parallelism statement. (#14323) Signed-off-by: Shanicky Chen <[email protected]> refactor(error): add more context for jvm error (#14302) chore: update help message for scale command (#14332) Signed-off-by: Shanicky Chen <[email protected]> fix: fix panic in `ctl meta source-split-info` (#14334) Signed-off-by: Shanicky Chen <[email protected]> test(streaming): add fuzz test for materialize handle conflict (#14166) add mock coordination
yezizp2012
added a commit
that referenced
this pull request
Jan 5, 2024
Signed-off-by: Shanicky Chen <[email protected]> Co-authored-by: Shanicky Chen <[email protected]> Co-authored-by: August <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Summary
This pull request introduces a new function
handle_alter_parallelismand a new variantSetParallelismin thealter_index_operationenum to handle theALTER_INDEXstatement. Thehandle_alter_parallelismfunction is responsible for checking the validity of theparallelismvalue. Additionally, thehandlefunction has been modified to handle theSetParallelismoperation.Changes Made
handle_alter_parallelismto handle theALTER_INDEXstatement.SetParallelismin thealter_index_operationenum.handlefunction to accommodate theSetParallelismoperation.Reasons for Changes
The existing code did not support the
ALTER_INDEXstatement and did not provide any mechanism to check the validity of theparallelismvalue. Therefore, this pull request aims to introduce a new function and enum variant to handle theALTER_INDEXstatement and ensure the validity of theparallelismvalue.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.