Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dummy table fragments are not persist when drop sink with table replacement #14299

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Jan 2, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #14297 . The root cause is that in #14191 we forward storing table fragments in ddl controller for compatibility but forget to do it for DROP SINK when merging main branch. 🥵

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Jan 2, 2024
@yezizp2012 yezizp2012 changed the title fix: fix error of drop sink for sink into table fix: dummy table fragments are not persist when drop sink with table replacement Jan 2, 2024
@yezizp2012 yezizp2012 enabled auto-merge January 2, 2024 08:55
@yezizp2012 yezizp2012 added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit 43383aa Jan 2, 2024
34 of 35 checks passed
@yezizp2012 yezizp2012 deleted the fix/drop-sink-into-table-fail branch January 2, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sink into table e2e fails after #14191
3 participants