-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sink): exclude java iceberg and deltalake sink from connector node #14277
Changes from all commits
1c673ea
2471b5c
a58e3ad
349bae3
6e73230
5397607
1a4d1b8
b43c67f
bd1e6e8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,15 @@ | ||
CREATE SINK bhv_iceberg_sink | ||
FROM | ||
bhv_mv WITH ( | ||
connector = 'iceberg_java', | ||
connector = 'iceberg', | ||
type = 'upsert', | ||
primary_key = 'user_id, target_id, event_timestamp', | ||
warehouse.path = 's3://hummock001/iceberg-data', | ||
s3.endpoint = 'http://minio-0:9301', | ||
s3.access.key = 'hummockadmin', | ||
s3.secret.key = 'hummockadmin', | ||
database.name='demo_db', | ||
table.name='demo_table' | ||
s3.region = 'us-east-1', | ||
catalog.type = 'storage', | ||
database.name='demo', | ||
table.name='demo_db.demo_table' | ||
); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,6 @@ use risingwave_connector::sink::{ | |
SINK_TYPE_UPSERT, SINK_USER_FORCE_APPEND_ONLY_OPTION, | ||
}; | ||
use risingwave_pb::stream_plan::stream_node::PbNodeBody; | ||
use tracing::info; | ||
|
||
use super::derive::{derive_columns, derive_pk}; | ||
use super::generic::GenericPlanRef; | ||
|
@@ -150,13 +149,6 @@ impl StreamSink { | |
Distribution::Single => RequiredDist::single(), | ||
_ => { | ||
match properties.get("connector") { | ||
Some(s) if s == "deltalake" => { | ||
// iceberg with multiple parallelism will fail easily with concurrent commit | ||
// on metadata | ||
// TODO: reset iceberg sink to have multiple parallelism | ||
Comment on lines
-154
to
-156
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the parallelism requirement for iceberg rust version There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The comment was for previous iceberg sink. Now there is no singleton requirement on both iceberg sink and delta lake sink. |
||
info!("setting iceberg sink parallelism to singleton"); | ||
RequiredDist::single() | ||
} | ||
Some(s) if s == "jdbc" && sink_type == SinkType::Upsert => { | ||
if sink_type == SinkType::Upsert && downstream_pk.is_empty() { | ||
return Err(ErrorCode::SinkError(Box::new(Error::new( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a user facing change?