Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Revert "feat(sink): support format encode syntax for sink into table (#14134) #14258

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Dec 28, 2023

This reverts commit 29e62e6.

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Because we have not reached a consensus If we will use the FORMAT ... ENCODE ... for all the sinks. And declare FORMAT ENCODE for a sink to the table is a little strange

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@st1page st1page changed the title Revert "feat(sink): support format encode syntax for sink into table (#14134) feat: Revert "feat(sink): support format encode syntax for sink into table (#14134) Dec 28, 2023
@st1page st1page enabled auto-merge December 28, 2023 09:32
@st1page st1page added this pull request to the merge queue Dec 28, 2023
Merged via the queue into main with commit fffff6d Dec 28, 2023
28 of 31 checks passed
@st1page st1page deleted the sts/revert branch December 28, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants