chore(agg): comment out bad row count panic
#14232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Chien <[email protected]>
stdrc
requested review from
TennyZhuang,
fuyufjh,
wangrunji0408,
BugenZhao and
st1page
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
st1page
reviewed
Dec 27, 2023
BugenZhao
reviewed
Dec 27, 2023
st1page
approved these changes
Dec 27, 2023
Co-authored-by: stonepage <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
wangrunji0408
approved these changes
Dec 27, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 28, 2023
Signed-off-by: Richard Chien <[email protected]> Co-authored-by: stonepage <[email protected]>
lmatz
pushed a commit
that referenced
this pull request
Dec 28, 2023
Signed-off-by: Richard Chien <[email protected]> Co-authored-by: Richard Chien <[email protected]> Co-authored-by: stonepage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As widely and deeply discussed in #14031 and many slack threads, seems we finally decided to tolerate inconsistent data in the stream. So this PR makes HashAgg not panic when encounter inconsistent
DELETEs. In the future we may introduce a sys param or session variable to allow user turn on strict mode to ensure consistency.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.