Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(monitor): add info log for client dns resolve #14229

Merged
merged 2 commits into from
Dec 27, 2023
Merged

chore(monitor): add info log for client dns resolve #14229

merged 2 commits into from
Dec 27, 2023

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Dec 27, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add rpc client dns resolve info log.

#14207

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@arkbriar arkbriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Pin::new(&mut self.inner).poll(cx).map(|res| match res {
Ok(addrs) => {
let addrs: MonitoredGaiAddrs = addrs.into();
info!("resolve {} => {:?}", self.name, addrs.inner);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more appropriate to log in DEBUG level.

Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrCroxx MrCroxx enabled auto-merge December 27, 2023 07:14
@MrCroxx MrCroxx added this pull request to the merge queue Dec 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 27, 2023
@MrCroxx MrCroxx added this pull request to the merge queue Dec 27, 2023
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

Merged via the queue into main with commit 641e522 Dec 27, 2023
26 of 27 checks passed
@MrCroxx MrCroxx deleted the xx/resolve branch December 27, 2023 08:23
github-actions bot pushed a commit that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants