Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make some source log debug instead of info #14225

Merged
merged 1 commit into from
Jan 2, 2024
Merged

chore: make some source log debug instead of info #14225

merged 1 commit into from
Jan 2, 2024

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Dec 27, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

SCR-20231227-hhm
SCR-20231227-hjd

When the parallelism is high, the log can easily fill up several pages.
The logs seem only useful for developers who want to do debugging.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@tabVersion
Copy link
Contributor

It should be ok if one source only print once? I think it is helpful to see if source works as expected.

@lmatz lmatz added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit 7c84d06 Jan 2, 2024
28 of 29 checks passed
@lmatz lmatz deleted the lz/log branch January 2, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants