Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make json/csv right #14222

Merged
merged 5 commits into from
Dec 27, 2023
Merged

fix: make json/csv right #14222

merged 5 commits into from
Dec 27, 2023

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Dec 26, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

bug desc: in prev impl, the it will use the json parser but in #13707, the parser type mapping changed to plain parser so s3 reader no longer use nd-streaming (split the lines by delimiter) and the regular parser does not recognize the contents.

fix: use SpecificParserConfig to do the mapping rather than via ByteStreamSourceParserImpl

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Dec 26, 2023
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
@Rossil2012 Rossil2012 marked this pull request as ready for review December 27, 2023 01:51
Copy link
Contributor

@Rossil2012 Rossil2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tabVersion tabVersion added this pull request to the merge queue Dec 27, 2023
Merged via the queue into main with commit fcaa318 Dec 27, 2023
29 of 30 checks passed
@tabVersion tabVersion deleted the tab/fix-s3-ci branch December 27, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants