Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): support table watermark filter for in-mem state store #14192

Merged
merged 7 commits into from
Dec 28, 2023

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Dec 25, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In this PR, we support table watermark filter for in-mem and sled state store.

The current seal_current_epoch method of LocalStateStore is not an async method, but in this PR, we need to call ingest_batch method of StateStoreWrite, which is an async method. Therefore we change the ingest_batch method to an non-async method as well. Some refactors are done accordingly.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 requested review from hzxa21 and Li0k December 25, 2023 11:14
@Li0k
Copy link
Contributor

Li0k commented Dec 27, 2023

update the PR description?

Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenym1 wenym1 added this pull request to the merge queue Dec 28, 2023
Merged via the queue into main with commit afd1fee Dec 28, 2023
29 of 30 checks passed
@wenym1 wenym1 deleted the yiming/mem-state-store-table-watermark branch December 28, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants