refactor(meta): readability improvements on source manager #14170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Dec 24, 2023
xxchan
force-pushed
the
12-23-refactor_meta_readability_improvements_on_source_manager
branch
2 times, most recently
from
527813c to
bf4f58f
Compare
|
requested review from 😄s |
yezizp2012
reviewed
Dec 26, 2023
xxchan
commented
Dec 26, 2023
Comment on lines
1102
to
1129
| Some( | ||
| { | ||
| 0: [ | ||
| TestSplit { | ||
| id: 2, | ||
| }, | ||
| ], | ||
| 1: [ | ||
| TestSplit { | ||
| id: 0, | ||
| }, | ||
| ], | ||
| 2: [ | ||
| TestSplit { | ||
| id: 1, | ||
| }, | ||
| ], | ||
| }, | ||
| ) | ||
| "#]], |
There was a problem hiding this comment.
It seems this isn't deterministic. Need to fix test
There was a problem hiding this comment.
fixed. slightly modified the logic of reassign_splits
xxchan
force-pushed
the
12-23-refactor_meta_readability_improvements_on_source_manager
branch
from
916e1fb to
58fa545
Compare
|
Need an approval from Cargo.lock @stdrc |
BugenZhao
approved these changes
Dec 28, 2023
stdrc
approved these changes
Dec 28, 2023
xxchan
deleted the
12-23-refactor_meta_readability_improvements_on_source_manager
branch
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.