Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): Add starrocks redis doris cassandra e2e test #14142

Merged
merged 10 commits into from
Feb 23, 2024

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Dec 22, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#13605

And added some minor changes to starrock by the way!
Refine the error for INTERVAL, TIME, and BYTEA.
mysqlport => query_port
httpport => http_port

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

fix

fix doris docker

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix
@xxhZs xxhZs force-pushed the xxh/add-sink-e2e-test branch 7 times, most recently from ab459c6 to 6abdd2e Compare December 26, 2023 08:25
@xxhZs xxhZs force-pushed the xxh/add-sink-e2e-test branch 4 times, most recently from 503307e to 0c07a74 Compare December 26, 2023 09:58
fix

fix

fix doris

fix

fix

fix

fix

test

save

fix

fix

fix

fix
@xxhZs xxhZs force-pushed the xxh/add-sink-e2e-test branch from 0c07a74 to 5e3a1ee Compare December 26, 2023 10:18
@xxhZs xxhZs requested a review from wenym1 December 26, 2023 10:30
Copy link

gitguardian bot commented Feb 22, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic Password 83e4ad7 e2e_test/source/cdc/cdc.load.slt View secret
- Generic Password 83e4ad7 e2e_test/source/cdc/cdc.load.slt View secret
- Generic Password 83e4ad7 e2e_test/source/cdc/cdc.load.slt View secret
- Generic Password 83e4ad7 e2e_test/source/cdc/cdc.load.slt View secret
- Generic Password 83e4ad7 e2e_test/source/cdc/cdc.load.slt View secret
9425213 Triggered Generic Password 9784265 ci/scripts/regress-test.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xxhZs xxhZs enabled auto-merge February 22, 2024 08:56
auto-merge was automatically disabled February 23, 2024 01:45

Merge queue setting changed

@xxhZs xxhZs added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit d8cca2a Feb 23, 2024
33 of 34 checks passed
@xxhZs xxhZs deleted the xxh/add-sink-e2e-test branch February 23, 2024 03:27
xxhZs added a commit that referenced this pull request Feb 23, 2024
command: >
sh -c "sudo sysctl -w vm.max_map_count=2000000"
environment:
- FE_SERVERS=fe1:172.121.0.2:9010
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use fe1:doris-fe-server:9010 here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants