-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show thread name in logs for playground and standalone #14114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
changed the title
feat: show thread name in logs
feat: show thread name in logs for playground and standalone
Dec 21, 2023
Signed-off-by: Bugen Zhao <[email protected]>
kwannoel
approved these changes
Dec 21, 2023
TennyZhuang
approved these changes
Dec 21, 2023
wenym1
approved these changes
Dec 21, 2023
StrikeW
approved these changes
Dec 21, 2023
@@ -359,7 +369,7 @@ pub fn init_risingwave_logger(settings: LoggerSettings) { | |||
let otel_tracer = { | |||
let runtime = tokio::runtime::Builder::new_multi_thread() | |||
.enable_all() | |||
.thread_name("risingwave-otel") | |||
.thread_name("rw-otel") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does otel
mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the abbreviation of opentelemetry
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
See backgrounds from #13988.
Not sure if the current thread names help much but I guess it's a good to have.
tracing_slf4j
. This is not restricted to the playground or standalone profile.Preview:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.