Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimizer): support array subquery and \du #14044

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Dec 18, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Example:

dev=> \du
                                   List of roles
 Role name |                         Attributes                         | Member of
-----------+------------------------------------------------------------+-----------
 postgres  | Superuser, Create role, Create DB, Replication, Bypass RLS | {NULL}
 root      | Superuser, Create role, Create DB, Replication, Bypass RLS | {NULL}

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

  • Support array subquery.
  • Support \du command.

@chenzl25 chenzl25 added the user-facing-changes Contains changes that are visible to users label Dec 18, 2023
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test case for the \du query as well? Similar to L125-L135

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4ba7281) 68.01% compared to head (c60d0d7) 68.09%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/frontend/src/planner/select.rs 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14044      +/-   ##
==========================================
+ Coverage   68.01%   68.09%   +0.07%     
==========================================
  Files        1543     1543              
  Lines      267096   267123      +27     
==========================================
+ Hits       181675   181892     +217     
+ Misses      85421    85231     -190     
Flag Coverage Δ
rust 68.09% <96.29%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenzl25 chenzl25 added this pull request to the merge queue Dec 18, 2023
Merged via the queue into main with commit fa1afbf Dec 18, 2023
26 of 27 checks passed
@chenzl25 chenzl25 deleted the dylan/support_array_subquery branch December 18, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support \du when using psql
3 participants