fix(meta): reduce time complexity of MinOverlappingPicker #14036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Little-Wallace <[email protected]>
Li0k
approved these changes
Dec 18, 2023
MrCroxx
reviewed
Dec 18, 2023
| level_handlers, | ||
| stats, | ||
| ) { | ||
| return Some(input); |
There was a problem hiding this comment.
If there is always some SST that can be trivial-moved, will early-return here be a problem?
There was a problem hiding this comment.
It is still right. Because Trivial Move task always has the smallest score(which is zero). So MinOverlappingPicker will still return the SST that can be trivial-moved at first.
Signed-off-by: Little-Wallace <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14036 +/- ##
==========================================
- Coverage 68.07% 67.98% -0.09%
==========================================
Files 1542 1542
Lines 266904 266914 +10
==========================================
- Hits 181682 181462 -220
- Misses 85222 85452 +230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
Signed-off-by: Little-Wallace <[email protected]>
huangjw806
pushed a commit
that referenced
this pull request
Dec 18, 2023
…14043) Signed-off-by: Little-Wallace <[email protected]> Co-authored-by: Wallace <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
close #10109
When there are too many small files in base level, meta-node may cost too much time to pick one task. Because the time complexity of
MinOverlappingPickeris O(N^2*k), where k represent the overlap size of next level.But most of case could be solved by trivial move, so we can pick trivial move file at the beginning of picker. The time complexity of
TrivialMovePickeris O(N*logN).Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.