-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stream): reuse label guarded metrics for actor input output metrics #13994
fix(stream): reuse label guarded metrics for actor input output metrics #13994
Conversation
… yiming/add_target_source_to_actor_input_output_rows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13994 +/- ##
==========================================
- Coverage 67.99% 67.97% -0.03%
==========================================
Files 1536 1536
Lines 265403 265430 +27
==========================================
- Hits 180462 180414 -48
- Misses 84941 85016 +75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…cs (#13994) Co-authored-by: Eric Fu <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fix #13948
The cause is the same as described in #13966 (comment).
The reason for failing to resolve the issue with #13966 (comment) is that, in d1fedcb, in the metric report of
dispatch
, we callwith_label_values
in eachdispatch
call similar to in other code in the commit. However, the other code is generating long existing streams, but thedispatch
is a async method call. So the value returned fromwith_label_values
indispatch
is still dropped immediately, and the problem still exists.Actually in d1fedcb the problem is half resolved. The actor input metrics is reported correctly already with the fix. In this PR we change to store the value returned from
with_label_values
as a field in the dispatch executor. The actor output metrics is reported correctly now.Following in the grafana dashboard, we first run in d1fedcb, the input metrics is fixed while the output metrics is still with problem. Later we run code in this PR, and both the input and output metrics is fixed.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.