fix(storage): lock table may cause deadlock and block iter

[Little-Wallace]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #13943

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added test labels as necessary. See details.
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[codecov]

Codecov Report

Attention: 189 lines in your changes are missing coverage. Please review.

Comparison is base (1e56cdb) 68.06% compared to head (3860921) 68.04%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
src/connector/src/sink/deltalake.rs	51.10%	177 Missing ⚠️
src/common/src/array/arrow/arrow_impl.rs	55.00%	9 Missing ⚠️
src/connector/src/sink/mod.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13979      +/-   ##
==========================================
- Coverage   68.06%   68.04%   -0.03%     
==========================================
  Files        1535     1536       +1     
  Lines      265039   265364     +325     
==========================================
+ Hits       180407   180568     +161     
- Misses      84632    84796     +164     

Flag	Coverage Δ
rust	68.04% <51.41%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hzxa21]

Can you explain how the deadlock happens in the PR description?

[Little-Wallace]

Can you explain how the deadlock happens in the PR description?

I do not understand, but the trace stack show that it hung on lock-table.

[MrCroxx]

Can you explain how the deadlock happens in the PR description?

I do not understand, but the trace stack show that it hung on lock-table.

Is there a await tree dump?

[chenzl25]

Related issue #13932

[chenzl25]

Just have tested a backfill on a table with only 1 parallelism and it succeeds, so it is a deadlock between different parallelism.

[chenzl25]

We should hold the LockGuard before calling the notified, otherwise, no one would drop the guard when the future is dropped in that await point.

        let lock = LockGuard {
            key,
            locks: self.locks.clone(),
        };
        if let Some(notify) = notify {
            notify.notified().await;
        }
        return lock

[st1page]

Can you explain how the deadlock happens in the PR description?

I do not understand, but the trace stack show that it hung on lock-table.

Is there a await tree dump?

https://risingwave-labs.slack.com/archives/C069B78AXDW/p1702439327854279