-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add statement_timeout for query. #13933
Conversation
a6413c9
to
9fe649f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13933 +/- ##
==========================================
- Coverage 68.05% 68.04% -0.01%
==========================================
Files 1533 1533
Lines 264453 264529 +76
==========================================
+ Hits 179964 180000 +36
- Misses 84489 84529 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
query: Query, | ||
can_timeout_cancel: bool, | ||
) -> Result<LocalQueryStream> { | ||
let timeout = if cfg!(madsim) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bug in madsim which may lead to invalid memory access. We skip madsim using this approach for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Close #7409 .
Releated #9732.
In this pr we add
statement_timeout
for dql statement, other ddl, dml statements are not affected. The default value is 1 hour.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
User can run
set statement_timeout = 10
to set the value for session. And the default value is in configbatch.statement_timeout_in_sec
, default value is 1 hour.