-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(expr): move several expressions to expr_impl
#13923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Runji Wang <[email protected]>
- coalesce - field - in - vnode Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
wangrunji0408
force-pushed
the
wrj/migrate-exprs
branch
from
December 11, 2023 12:33
60e745e
to
a6e981a
Compare
Signed-off-by: Runji Wang <[email protected]>
wangrunji0408
force-pushed
the
wrj/migrate-exprs
branch
from
December 11, 2023 13:20
a3a82e9
to
b8c5680
Compare
TennyZhuang
approved these changes
Dec 11, 2023
Signed-off-by: Runji Wang <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13923 +/- ##
==========================================
+ Coverage 68.07% 68.10% +0.02%
==========================================
Files 1532 1533 +1
Lines 264568 264434 -134
==========================================
- Hits 180114 180094 -20
+ Misses 84454 84340 -114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Tips: click here to review code, ignoring file moves.
This PR moves the following expressions from
expr
crate toexpr_impl
crate:and migrates their constructors to
#[build_function]
, as well as their unit tests.The syntax of struct types in
DataChunk::from_pretty
is changed to match postgres literals.The
risingwave_udf
crate is moved to theexpr
folder.Checklist
./risedev check
(or alias,./risedev c
)Documentation