chore(storage): adjust compaction task priority and fix memory estimation #13914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto li0k/storage_fix
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13914 +/- ##
==========================================
- Coverage 68.06% 67.98% -0.08%
==========================================
Files 1542 1542
Lines 266890 266905 +15
==========================================
- Hits 181646 181454 -192
- Misses 85244 85451 +207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zwang28
reviewed
Dec 15, 2023
| @@ -78,18 +96,22 @@ pub fn append_sstable_info_to_string(s: &mut String, sstable_info: &SstableInfo) | |||
| hex::encode(key_range.right.as_slice()) | |||
| }; | |||
|
|
|||
| let ratio = sstable_info.stale_key_count * 100 / sstable_info.total_key_count; | |||
| let stale_ratio = sstable_info.stale_key_count * 100 / sstable_info.total_key_count; | |||
There was a problem hiding this comment.
good catch,
It is not expected that there will be an sst with total_key_count = 0, however, I can't guarantee that the arguments passed by the caller are compliant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.