Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(object store): bump OpenDAL to v0.43 #13901

Merged
merged 4 commits into from
Dec 11, 2023
Merged

chore(object store): bump OpenDAL to v0.43 #13901

merged 4 commits into from
Dec 11, 2023

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Dec 11, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

When implementing opendal source, we need the prefix list feature, which should pin the specific git commit. But this is a bit incompatible with the 0.41 version currently used in the object store, so this pr bump OpenDAL to v0.43.

This time it’s break change:

op.list_with(path).delimiter("") -> op.list_with(path).recursive(true)
op.list_with(path).delimiter("/") -> op.list_with(path).recursive(false)

refer to https://opendal.apache.org/docs/rust/opendal/docs/upgrade/index.html

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wcy-fdu wcy-fdu requested a review from a team as a code owner December 11, 2023 04:43
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcy-fdu wcy-fdu enabled auto-merge December 11, 2023 06:57
@wcy-fdu wcy-fdu added this pull request to the merge queue Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a3c71aa) 68.10% compared to head (05c401b) 68.17%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../src/object/opendal_engine/opendal_object_store.rs 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13901      +/-   ##
==========================================
+ Coverage   68.10%   68.17%   +0.07%     
==========================================
  Files        1529     1529              
  Lines      264150   264169      +19     
==========================================
+ Hits       179892   180101     +209     
+ Misses      84258    84068     -190     
Flag Coverage Δ
rust 68.17% <91.30%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 4d525e2 Dec 11, 2023
7 of 8 checks passed
@wcy-fdu wcy-fdu deleted the wcy/bump_opendal branch December 11, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants